Skip to content

chore(aci): Remove uses of workflow-engine-post-process-async flag #95382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025

Conversation

kcons
Copy link
Member

@kcons kcons commented Jul 11, 2025

Nobody is opted out anymore, turning this off could pose significant operational risk to post_process, and any value as a kill switch is already covered by the more general opt-in flags.

@kcons kcons requested a review from a team July 11, 2025 21:45
@kcons kcons requested a review from a team as a code owner July 11, 2025 21:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 11, 2025
cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/tasks/post_process.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #95382       +/-   ##
===========================================
+ Coverage   56.19%   87.80%   +31.60%     
===========================================
  Files       10476    10491       +15     
  Lines      605899   606214      +315     
  Branches    23711    23711               
===========================================
+ Hits       340484   532261   +191777     
+ Misses     265057    73595   -191462     
  Partials      358      358               

@kcons kcons marked this pull request as draft July 11, 2025 22:02
Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change lgtm, but looks like a test or two might need to be updated now

@kcons kcons marked this pull request as ready for review July 14, 2025 16:14
@kcons kcons requested a review from a team as a code owner July 14, 2025 16:21
@kcons kcons enabled auto-merge (squash) July 14, 2025 16:21
@kcons kcons merged commit 94a03f0 into master Jul 14, 2025
65 checks passed
@kcons kcons deleted the kcons/delflag branch July 14, 2025 16:40
andrewshie-sentry pushed a commit that referenced this pull request Jul 14, 2025
…95382)

Nobody is opted out anymore, turning this off could pose significant
operational risk to post_process, and any value as a kill switch is
already covered by the more general opt-in flags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants